Combine ignored CVEs from both --config with --ignore flag#422
Open
GoutamSingired wants to merge 1 commit intorubysec:masterfrom
Open
Combine ignored CVEs from both --config with --ignore flag#422GoutamSingired wants to merge 1 commit intorubysec:masterfrom
GoutamSingired wants to merge 1 commit intorubysec:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Current state
Currently, the
--ignoreflag overwrites the ignored CVEs from a config file (--config):bundler-audit/lib/bundler/audit/scanner.rb
Lines 221 to 225 in d8af649
With
config.optionscoming from the passed configuration file:bundler-audit/lib/bundler/audit/scanner.rb
Lines 91 to 95 in d8af649
Why this would come in handy
In our CI pipelines, we have some template jobs that run
bundle-auditacross all projects. We also have a.bundler-audit.ymlconfig file to ignore specific CVEs on a per-project basis. If we now want to ignore a CVE across all projects, we have to add the CVE to the ignore file in each project. If the CVEs from the "global"--ignoreflag and the config file would be taken both into account, we could just add the CVEs to be ignored globally to the--ignoreparameter.Potential implementation
Solution: merge the two sets instead of taking one or the other.
Original Issue:
#388